Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasSubModels automatic deriving ergonomics #108

Merged
merged 16 commits into from
Jun 30, 2022
Merged

HasSubModels automatic deriving ergonomics #108

merged 16 commits into from
Jun 30, 2022

Conversation

srid
Copy link
Owner

@srid srid commented Jun 30, 2022 •
edited
Loading

Resolves #107

  • DerivingVia
  • generics
  • Stretch
    • Can we use it for 'const model' case? Drop NPConst?
    • Add view (subModelLens (_As @"R_Static")) m?

srid
srid commented Jun 30, 2022
View reviewed changes
src/Ema/Example/Ex04_Multi.hs Outdated Show resolved Hide resolved
@srid
Copy link
Owner Author

srid commented Jun 30, 2022 •
edited
Loading

Would be interesting if we could define lens at type-level.

EDIT: HasAny achieves the same goal.

@srid srid mentioned this pull request Jun 30, 2022
Open
@srid srid changed the title WIP: HasSubModels ergonomics HasSubModels automatic deriving ergonomics Jun 30, 2022
@srid srid marked this pull request as ready for review June 30, 2022 23:30
@srid srid merged commit 25732cd into multisite Jun 30, 2022
@srid srid deleted the multisite--submodel branch June 30, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srid