Pass children to order function in treeSplice #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
reviewed
Dec 23, 2022
Comment on lines
-25
to
+26
| flip foldMapM (sortOn (sortKey . extendPars . rootLabel) trees) $ \(Node lbl children) -> do | ||
| let sorter x = sortKey (extendPars $ rootLabel x) (subForest x) | ||
| flip foldMapM (sortOn sorter trees) $ \(Node lbl children) -> do |
There was a problem hiding this comment.
let sortKey' = flip sortKey (subForest x)? Then the existing code would require minimal changes here, and below.
There was a problem hiding this comment.
But where would the x come from?
There was a problem hiding this comment.
Oh, right. Okay I'll review all your PRs by this weekend.
|
bors try |
tryBuild succeeded: |
|
@jfpedroza I wasn't able to push to this branch. Did you open the PR with "Allow repository author to make changes" (something of that ilk) option disabled? |
|
FYI: c5e6d86 |
Apparently, I did. I must have disabled it without noticing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the children of a node to the sorter in
Heist.Extra.Splices.Tree.treeSpliceto be able to put folders first.