Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Absolute path for local path in the binds structure #177

Closed
hellt opened this issue Nov 23, 2020 · 0 comments · Fixed by #183
Closed

implement Absolute path for local path in the binds structure #177

hellt opened this issue Nov 23, 2020 · 0 comments · Fixed by #183

Comments

@hellt
Copy link
Member

hellt commented Nov 23, 2020

Currently, the string we accept in binds section does not get expanded if it contains bash variables.

To make it more useful, we should translate the ${PWD} and/or relative paths such as ./dir
@hellt hellt changed the title implement expanding of ${PWD} in binds implement Absolute path for local path in the binds structure Nov 24, 2020
hellt added a commit that referenced this issue Nov 29, 2020
@hellt
implement Absolute path for local path in the binds structure #177
0d31338
@hellt hellt mentioned this issue Nov 29, 2020
Merged
hellt added a commit that referenced this issue Nov 30, 2020
@hellt
implement Absolute path for local path in the binds structure #177
74d514b
@hellt hellt closed this as completed in #183 Dec 1, 2020
hellt added a commit that referenced this issue Dec 1, 2020
@hellt
Binds abspath (#183)
baad0e3 
* added homedir resolve process for license paths

* added homedir module

* remove excessive comments

* improved license init logic

* moved path resolving logic to a separate path

* added tests

* implement Absolute path for local path in the binds structure #177

* added tests for binds propagation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Binds abspath srl-labs/containerlab
1 participant
@hellt