Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Marker parameters should be kwarg only #354

Closed
trickeydan opened this issue Jul 26, 2019 · 0 comments · Fixed by #481
Closed

Marker parameters should be kwarg only #354

trickeydan opened this issue Jul 26, 2019 · 0 comments · Fixed by #481
Labels
enhancement New feature or request good first issue Good for newcomers typing A incorrect or loose type that needs correcting.
Milestone
v0.8.0

Comments

@trickeydan
Copy link
Contributor

trickeydan commented Jul 26, 2019 •
edited
Loading 

    def __init__(self,
                 id: int,
                 position: Coordinate,
                 pixel_corners: Optional[Sequence[PixelCoordinates]] = None,
                 pixel_centre: Optional[PixelCoordinates] = None,
                 *,  # We need to move this before pixel_corners.
                 orientation: Optional[Orientation] = None,
                 ):
@trickeydan trickeydan added enhancement New feature or request good first issue Good for newcomers typing A incorrect or loose type that needs correcting. labels Jul 26, 2019
@trickeydan trickeydan added this to the v0.8.0 milestone Dec 10, 2019
trickeydan added a commit that referenced this issue Dec 10, 2019
@trickeydan
Enforce kwargs for Marker.{pixel_corners, pixel_centre}
1112a71 
Fixes #354
@trickeydan trickeydan mentioned this issue Dec 10, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Nov 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers typing A incorrect or loose type that needs correcting.
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Minor Updates to Marker Class srobo/j5
1 participant
@trickeydan