-
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gone through tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, though I've got a few bits of feedback.
I'm unlikely to get a chance to test this on hardware until term starts, but I trust you've done some good testing on this already.
Looks like some things broke when #233 (change lists to sets) was merged into this branch. Once these are fixed I think this PR is good to go. |
Code Climate has analyzed commit bcd4102 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 98.3% (0.2% change). View more on Code Climate. |
This is a huge PR, commit - by - commit review is recommended. Putting docs separately as this is already big.
Closes #63