Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

SR v4 Motor Board #227

Merged
merged 21 commits into from
Apr 19, 2019
Merged

SR v4 Motor Board #227

merged 21 commits into from
Apr 19, 2019

Conversation

trickeydan
Copy link
Contributor

@trickeydan trickeydan commented Apr 10, 2019

  • Motor Board Class
  • Motor Board Class tests
  • Hardware Implementation
  • Hardware Implementation tests
  • Console Implementation
  • Console Implementation tests

This is a huge PR, commit - by - commit review is recommended. Putting docs separately as this is already big.

Closes #63

@trickeydan trickeydan added this to the v0.3.0 milestone Apr 10, 2019
tests_hw/test_motor_board.py Outdated Show resolved Hide resolved
tests_hw/test_motor_board.py Outdated Show resolved Hide resolved
@srobo srobo deleted a comment from codeclimate bot Apr 14, 2019
@trickeydan trickeydan marked this pull request as ready for review April 14, 2019 19:45
Copy link
Contributor

@Skybound1 Skybound1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gone through tests...

j5/backends/console/sr/v4/motor_board.py Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Outdated Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Outdated Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Show resolved Hide resolved
j5/boards/sr/v4/motor_board.py Show resolved Hide resolved
Copy link
Contributor

@kierdavis kierdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, though I've got a few bits of feedback.

I'm unlikely to get a chance to test this on hardware until term starts, but I trust you've done some good testing on this already.

j5/boards/sr/v4/motor_board.py Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Outdated Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Outdated Show resolved Hide resolved
j5/backends/hardware/sr/v4/motor_board.py Outdated Show resolved Hide resolved
@kierdavis
Copy link
Contributor

Looks like some things broke when #233 (change lists to sets) was merged into this branch. Once these are fixed I think this PR is good to go.

@codeclimate
Copy link

codeclimate bot commented Apr 19, 2019

Code Climate has analyzed commit bcd4102 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 98.3% (0.2% change).

View more on Code Climate.

@trickeydan trickeydan merged commit acbaf88 into master Apr 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the motor-board branch April 19, 2019 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SR v4 Motor Board
4 participants