Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Add a Battery sensor #70

Merged
merged 8 commits into from
Feb 13, 2019
Merged

Add a Battery sensor #70

merged 8 commits into from
Feb 13, 2019

Conversation

trickeydan
Copy link
Contributor

Closes #62.

@trickeydan trickeydan added the enhancement New feature or request label Feb 12, 2019
@trickeydan trickeydan added this to the Soft Boards Complete milestone Feb 12, 2019
sedders123
sedders123 suggested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@sedders123 sedders123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some minor nits

j5/components/battery_sensor.py Outdated Show resolved Hide resolved
tests/components/test_battery_sensor.py Outdated Show resolved Hide resolved
tests/components/test_battery_sensor.py Outdated Show resolved Hide resolved
sedders123 and others added 3 commits February 12, 2019 15:32
@sedders123 @trickeydan
Fix Typos from code review
60d0818 
Co-Authored-By: trickeydan <trickeydan@users.noreply.github.com>
@trickeydan
Add missing type
e194050
@trickeydan
Merge branch 'master' into battery-sensor
1694c72
trickeydan and others added 2 commits February 12, 2019 15:37
@trickeydan
Fix linting error caused by merge.
b0ead8b
@sedders123 @trickeydan
Update tests/components/test_battery_sensor.py
06c78ee 
Co-Authored-By: trickeydan <trickeydan@users.noreply.github.com>
sedders123
sedders123 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@sedders123 sedders123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have double checked all doc strings and this is the last one that is incorrect

tests/components/test_battery_sensor.py


class MockBatterySensorDriver(BatterySensorInterface):
"""A testing driver for the led."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""A testing driver for the led."""
"""A testing driver for the BatterySensor."""

@sedders123
Copy link
Member

Apologies for the multiple small reviews, have been doing this in between waiting for builds at work, next time I shall wait till I can be certain of a thorough review.

@trickeydan trickeydan merged commit 5bb38c6 into master Feb 13, 2019
@trickeydan trickeydan deleted the battery-sensor branch February 13, 2019 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kierdavis kierdavis kierdavis approved these changes

@sedders123 sedders123 sedders123 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trickeydan @sedders123 @kierdavis