-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimal support for Ruby 3 #473
Conversation
This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives. This works around: - github/pages-gem#752 - envygeeks/pathutil#5
29500c0
to
aeff6dd
Compare
As part of this, it might be nice to add Ruby 3 to the CI matrix, so we make sure we keep support. I'm not sure what timeframe you imagine us switching the default install to 3 ( I too share the plague of trying to use older Ruby versions). |
Well that kinda implies it's supported ... which it isn't.
At the moment, none. I don't think we can default to that until the production build (i.e: GitHub Pages itself) switches. In theory we could move to the manual github pages (via Actions) mechanism, but even then I'm not keen on the production build involving the level of hacks needed here. |
Essentially I see this at the moment as being for those who know what they're doing and want to risk Ruby 3, rather than something we want to encourage people to use. |
Rakefile
Outdated
|
||
# Fix pathutil on Ruby 3; works around https://github.com/envygeeks/pathutil/pull/5 | ||
# as suggested by https://stackoverflow.com/a/73909894/67873 | ||
sh('sed -i.bak "s/, kwd/, **kwd/" $(bundle exec gem which pathutil)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think sed
comes as standard on Windows. Can we do this in a cross platform way or only run this fix where sed
is available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0e143c
to
ef3e8cb
Compare
Ignore the CircleCI failure -- we don't use CircleCI for this project any more. |
We should switch over to building the site ourselves in GitHub Actions using the Publish to GitHub Pages action. This would allow us to use a more up to date version of Jekyll. |
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
If needed, reinstalling the gem is easy enough.
This ports the changes from srobo/website#473.
This ports the changes from srobo/website#473. This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.
This ports the changes from srobo/website#473. This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.
This ports the changes from srobo/website#473. This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.
This ports the changes from srobo/website#473. This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.
This isn't officially supported by Jekyll and is a bit hacky, so I'm deliberately not documenting the support, however as recent Ubuntu versions now ship with Ruby 3 (not 2.7) and Jekyll isn't showing any signs of moving towards supporting Ruby 3 we're not left with many alternatives.
This works around:
If we're happy with this fix I'll also apply it to our other Jekyll projects (docs, style, competition-website).