Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Browse Results Page, the TEI:title child element is not displaying #1

Closed
davidamichelson opened this issue Mar 2, 2020 · 13 comments
Assignees

Comments

@davidamichelson
Copy link
Collaborator

Screenshot 2020-03-02 10 36 13

The first record should read:
Ammianus Marcellinus. History, 14.11

Please wrap the title element in italics

p.s. all of these Caesarea work will be billed to a new PO

@davidamichelson
Copy link
Collaborator Author

In addition to wrapping /TEI/teiHeader/fileDesc/titleStmt/title/title in italics, please also wrap /TEI/text/body/desc[@type="abstract"]/title in italics.

@davidamichelson
Copy link
Collaborator Author

davidamichelson commented Mar 2, 2020

In addition the same title element is not wrapped in italics when it occurse in the How to Cite This Entry box (occurs four times in the how to cite box)

@wsalesky
Copy link
Collaborator

wsalesky commented Mar 9, 2020

@davidamichelson Could we add a @rend='italic' to the title element? That makes more sense to me than programing that a title nested in a title should always be rendered as italic.

wsalesky added a commit that referenced this issue Mar 9, 2020
Fix missing nested title display in browse menu. #1
@davidamichelson
Copy link
Collaborator Author

We could, though I am not sure if that is good design in TEI. My inclination is that any thing in a title element should render as italic. Let's discuss.

@wsalesky
Copy link
Collaborator

wsalesky commented Mar 9, 2020

@davidamichelson That is fine as long as titles should always be in italic. This is the TEI for the record in question:

<title xml:lang="en" level="a">
   Ammianus Marcellinus.
   <title>History</title>
14.11
</title>

So if titles are always in italic it would render as: Ammianus Marcellinus. History, 14.11

Or I can programtically only italicize a nested tei:title/tei:title, which would get the desired display.

@davidamichelson
Copy link
Collaborator Author

Hmm, yes I see the problem. Let's wait and discuss in person.

@davidamichelson
Copy link
Collaborator Author

Render title in italics if title@level="m"

@davidamichelson
Copy link
Collaborator Author

@wlpotter will change anywhere in the document (titleStmt, abstract)

@wlpotter
Copy link
Collaborator

Note to self, the titles that need to be changed appear here:

/TEI/teiHeader/fileDesc/titleStmt/title/title
/TEI/teiHeader/profileDesc/creation/title
/TEI/text/body/desc/title

wlpotter added a commit to srophe/caesarea-data that referenced this issue Mar 16, 2020
@wlpotter wlpotter assigned wsalesky and unassigned wlpotter Mar 16, 2020
@wlpotter
Copy link
Collaborator

@wsalesky this change has been made in the data

@wlpotter
Copy link
Collaborator

I just realized that I was working on the branch with the anchors, rather than on master...I will make the changes on master now

wlpotter added a commit to srophe/caesarea-data that referenced this issue Mar 16, 2020
Fixing data for srophe/caesarea#1

Had made this change to the wrong branch previously...
@wlpotter
Copy link
Collaborator

Okay, now the data on master should be correct.

@wsalesky
Copy link
Collaborator

Looks good on browse, needs to be added to the work page title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants