Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail_on_error: true doesn't seem to work #106

Closed
jrfnl opened this issue Nov 11, 2023 · 4 comments
Closed

fail_on_error: true doesn't seem to work #106

jrfnl opened this issue Nov 11, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jrfnl
Copy link

jrfnl commented Nov 11, 2023

As mentioned in passing in #105 :

I tried adding fail_on_error: true, but that gave me an Warning: Unexpected input(s) 'fail_on_error', valid inputs are ['entryPoint', 'args', 'config_path', 'use_local_config'] error.

The workflow I used while debugging the issue looked like this:

jobs:
  label-new-prs:
    runs-on: ubuntu-latest

    steps:
      # Checkout is needed to use the `use_local_config` option.
      - name: Checkout code
        uses: actions/checkout@v3

      - uses: srvaroa/labeler@master
        with:
          use_local_config: true
          fail_on_error: true
        env:
          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

Also note my comment about the need for checkout when using the use_local_config option. That might be something to mention in the README.

@srvaroa srvaroa self-assigned this Nov 11, 2023
@srvaroa
Copy link
Owner

srvaroa commented Nov 11, 2023

#107

I'll fix the checkout mention in a separate PR, thanks!

@srvaroa srvaroa added the bug Something isn't working label Nov 11, 2023
@srvaroa
Copy link
Owner

srvaroa commented Nov 11, 2023

Readme: #108

@srvaroa
Copy link
Owner

srvaroa commented Nov 11, 2023

This should be fixed now, thanks for reporting!

@srvaroa srvaroa closed this as completed Nov 11, 2023
@jrfnl
Copy link
Author

jrfnl commented Nov 11, 2023

@srvaroa Thank you Gala!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants