Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could a "moving" v1 tag be added to this repo ? #110

Closed
jrfnl opened this issue Nov 11, 2023 · 2 comments
Closed

Could a "moving" v1 tag be added to this repo ? #110

jrfnl opened this issue Nov 11, 2023 · 2 comments

Comments

@jrfnl
Copy link

jrfnl commented Nov 11, 2023

With action runners, it is generally considered bad practice to use @master as that will get you (the action user) into trouble when the action releases/is working on a new major version.

However, using a specific tag or even a specific commit @v1.7.1 means you continuously have to update the workflow. This is made easier with Dependabot, but still a pain in the neck.

To work-around this, a lot of action runners have a "moving" tag for each major. For this repo that would currently be v1, this tag would always be at the last tagged release of the 1.x range of releases.

By the time, a new major would be released, a new, moving v2 tag would then be added, which does the same for the 2.x range of releases.

That way, end-users only have to update their workflow on new majors (from @v1 to @v2), which Dependabot can handle, and they can avoid using @master and prevent unexpected surprises.

Would you be willing to consider this ?

@srvaroa
Copy link
Owner

srvaroa commented Nov 11, 2023

Sure, this makes total sense!

I've updated the README and added a v1. I'll keep this one up to date with future releases. Let me know if that works well.

@srvaroa srvaroa closed this as completed Nov 11, 2023
@jrfnl
Copy link
Author

jrfnl commented Nov 11, 2023

Thank you @srvaroa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants