Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken getPrFileNames() function #20

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Fix broken getPrFileNames() function #20

merged 1 commit into from
Oct 24, 2020

Conversation

posquit0
Copy link
Contributor

@posquit0 posquit0 commented Oct 21, 2020 •
edited
Loading

Background

  • The current getPrFileNames() function doesn't work.
  • https://github.com/:owner/:repo/pull/:number.diff doesn't accept Authorization token.
  • Closes Not work files condition #19

Problem Solving

Known Issues

  • github.com/waigani/diffparser package cannot parse correctly with renamed diff.

srvaroa
srvaroa approved these changes Oct 24, 2020
View reviewed changes
Copy link
Owner

@srvaroa srvaroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srvaroa srvaroa merged commit 9d5eff2 into srvaroa:master Oct 24, 2020
@posquit0
Copy link
Contributor Author

@srvaroa Could you add a label hacktoberfest-accepted to this PR for Hacktoberfest again? 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srvaroa srvaroa srvaroa approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not work files condition
2 participants
@posquit0 @srvaroa