Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcec >=v5 compatibility #19

Closed
ssalonen opened this issue Jan 27, 2022 · 1 comment
Closed

libcec >=v5 compatibility #19

ssalonen opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@ssalonen
Copy link
Owner

Bug description

See compilation problem against libcec6 ssalonen/cec-alsa-sync#7, and related issue in libcec-sys ssalonen/libcec-sys#10

This wrapper library should probably expose feature flags for different ABI versions

To Reproduce

Expected behavior

Screenshots

Environment

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
@ssalonen ssalonen added the bug Something isn't working label Jan 27, 2022
ssalonen added a commit that referenced this issue Jan 30, 2022
@ssalonen
wip #19
b2dfa7c 
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen mentioned this issue Feb 3, 2022
Merged
ssalonen added a commit that referenced this issue Feb 9, 2022
@ssalonen
Multi abi (#20)
432f184 
* wip  #19

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* approriate libcec API fn call for setting callbacks based on ABI

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* ABI smoke tests

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* better CI labels

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* depend on unrelease feature branch of libcec-sys

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* CI syntax fix

* fix attempt for libcec checkout by cargo

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* Tell cargo to use git cli for URL rewriting

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* More rewriting

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* Rewrite fix

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* URL rewrites

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* Some more url rewriting

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* workaround for submodule URL rewriting

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* syntax

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* syntaix

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* debug

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* debug2

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* ..

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* ...

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* Cargo fmt

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* fixing libcec-sys git feature branch checkout

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* libcec 3.0.0

Signed-off-by: Sami Salonen <ssalonen@gmail.com>

* fix coverage build

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen
Copy link
Owner Author

ssalonen commented Feb 9, 2022

Resolved in #20.

@ssalonen ssalonen closed this as completed Feb 9, 2022
trinitronx added a commit to trinitronx/cec-dpms that referenced this issue Jun 27, 2023
@trinitronx
Update cec-rs to 7.0.0 (libcec >=v5 compatibility)
52b73f0 
References:

  - ssalonen/cec-rs#19

  - ssalonen/cec-rs#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssalonen