adjust bfe.json so that only classic has sigils #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixmix
approved these changes
Aug 16, 2021
| return [...acc, ...type.formats.filter((format) => format.suffix)] | ||
| }, []) | ||
| const sigils = new Set() | ||
| loopOverTypes: for (const type of bfeTypes) { |
There was a problem hiding this comment.
Maybe the first or second time ever that I find a legit use case for it :)
There was a problem hiding this comment.
What's it called so I can learn what it is
There was a problem hiding this comment.
| ...acc, | ||
| ...type.formats.filter((format) => !format.sigil && format.suffix) | ||
| ] | ||
| , []) |
There was a problem hiding this comment.
I didn't really want to refactor it, but changing the structure of the json forced me to rethink this file, it would have been hard to keep it like it was before, so I just saved some time and followed the spirit of the previous test
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: See ssbc/ssb-meta-feeds-spec#19, only classic SSB refs would have sigils, so I started working on updating
ssb-bfe(JS) to use SSB URIs for all non-classic type/formats and it required updatingssb-bfe-spec.The main change is in
bfe.json, there is nowformat.sigilalongsideformat.suffix, whereas before it wastype.sigil(making an assumption that the sigil applies universally for that type). I also renamedmsgtomessagebecause if we are to usebfe.jsonprogramatically, we have to build the URI from it, andssb:msg/ed25519/is not an official SSB URI, it'sssb:message/ed25199/.