support encoding/decoding SSB URIs semantically #28
Conversation
staltz
commented
Aug 16, 2021
•
staltz
commented
- Code reviews
- Pending on ssb-uri for bendybutt feed ssb-meta-feeds-spec#25 merged first
- Pending on adjust bfe.json so that only classic has sigils ssb-bfe-spec#20 merged first
- Pending on a new version of ssb-bfe-spec released on npm and updated here
| @@ -6,7 +6,7 @@ const { bfeNamedTypes, bfeTypes } = bfe | |||
| tape('00 feed type', function (t) { | |||
| const values = [ | |||
| '@6CAxOI3f+LUOVrbAl0IemqiS7ATpQvr9Mdw9LC4+Uv0=.ed25519', // classic | |||
| '@6CAxOI3f+LUOVrbAl0IemqiS7ATpQvr9Mdw9LC4+Uv0=.bbfeed-v1', // bendy-butt | |||
| 'ssb:feed/bendybutt-v1/6CAxOI3f-LUOVrbAl0IemqiS7ATpQvr9Mdw9LC4-Uv0=', // bendy-butt | |||
There was a problem hiding this comment.
This diff makes it really nice and clear what's happening!
package.json
Outdated
| @@ -16,7 +16,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "is-canonical-base64": "^1.1.1", | |||
| "ssb-bfe-spec": "^0.1.1", | |||
| "ssb-bfe-spec": "github:ssb-ngi-pointer/ssb-bfe-spec#support-ssb-uris", | |||
There was a problem hiding this comment.
I think you can upgrade this to the module latest now
|
@mycognosist I think this is a PR you could review, and I can drop arj (assuming he has too much to work on, but obviously if arj has comments I gladly welcome them too). |
|
@staltz this looks good to me, just needs module installing I think. |
|
Thanks @mixmix . I won't merge this PR before updating ssb-bfe-spec to an npm version, and before marking it non-draft. Just wanted more feedback (from more people) on the code, so that once ssb-bfe-spec is ready, we are ready to merge. |
|
Due to the tests being fundamentally changed (even if just a little), this will have be a new breaking change version. |
