Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring visualization #80

Merged
merged 8 commits into from
Oct 22, 2021
Merged

Refactoring visualization #80

merged 8 commits into from
Oct 22, 2021

Conversation

dokempf
Copy link
Member

@dokempf dokempf commented Oct 22, 2021

This is quite a refactoring with these substeps:

  • Unify the interface: DataSet.show entrypoint allows switching between different kinds of visualizations
  • Visualization configuration is handled through schema
  • UI widgets are available for visualization - through DataSet.show_interactive and in widget apps
  • Integrate classification parameter into visualization widget
  • Adapt filter tuning app to work again and use the same infrastructure

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #80 (aeb8bdd) into main (9c8aecd) will decrease coverage by 1.76%.
The diff coverage is 67.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   85.68%   83.92%   -1.77%     
==========================================
  Files          14       14              
  Lines        1139     1163      +24     
==========================================
  Hits          976      976              
- Misses        163      187      +24     
Impacted Files Coverage Δ
adaptivefiltering/pdal.py 93.75% <ø> (-1.71%) ⬇️
adaptivefiltering/apps.py 33.10% <9.52%> (-3.79%) ⬇️
adaptivefiltering/widgets.py 76.58% <71.42%> (-0.42%) ⬇️
adaptivefiltering/dataset.py 89.23% <84.61%> (-3.53%) ⬇️
adaptivefiltering/visualization.py 99.04% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8aecd...aeb8bdd. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant