-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated yaml format #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 294 294
=========================================
Hits 294 294 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Change looks good to me and fixes the issue:
|
xydesa
approved these changes
Jun 21, 2022
denewiler
approved these changes
Jun 21, 2022
LGTM. Updated config file fixes the issues for me as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues running with this config in statick-action using the deprecated format for "inherits_from". This seems to fix it.
To test use a line like this: (running statick with default Markdown configuration on this repo itself)
statick --output-directory /tmp --profile md-profile.yaml --config md-config.yaml --user-paths ~/src/statick_md .
This is using v0.8.1 of statick and the 'main' branch of statick-md.
As an aside, none of the default configs in statick itself or statick-tooling appear to use the suggested new method. Should that be changed?
I did not attempt to solve the underlying issue with the old string method.