Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated yaml format #57

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

gregtkogut
Copy link
Collaborator

I had issues running with this config in statick-action using the deprecated format for "inherits_from". This seems to fix it.

To test use a line like this: (running statick with default Markdown configuration on this repo itself)
statick --output-directory /tmp --profile md-profile.yaml --config md-config.yaml --user-paths ~/src/statick_md .

This is using v0.8.1 of statick and the 'main' branch of statick-md.

As an aside, none of the default configs in statick itself or statick-tooling appear to use the suggested new method. Should that be changed?

I did not attempt to solve the underlying issue with the old string method.

@gregtkogut gregtkogut self-assigned this Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #57 (571e3eb) into main (fce32cd) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          294       294           
=========================================
  Hits           294       294           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xydesa
Copy link
Collaborator

xydesa commented Jun 21, 2022

Change looks good to me and fixes the issue:

(statick_venv) : ~/code/github/statick_ws/statick-web {main $%} $ statick . --output-directory /tmp/x --log info --profile md-profile.yaml --config md-config.yaml
INFO:root:Log level set to INFO
INFO:root:level: md_with_pylint
INFO:root:Writing output to: /tmp/x/statick-web-md_with_pylint
INFO:root:------
INFO:root:Scanning package statick-web (/home/axydes/code/github/statick_ws/statick-web) at level md_with_pylint
INFO:root:---Discovery---
Traceback (most recent call last):
  File "/home/axydes/code/github/statick_ws/statick_venv/bin/statick", line 50, in <module>
    main()
  File "/home/axydes/code/github/statick_ws/statick_venv/bin/statick", line 39, in main
    success = run(statick, parsed_args)
  File "/home/axydes/code/github/statick_ws/statick_venv/bin/statick", line 14, in run
    issues, success = statick.run(path, parsed_args)
  File "/home/axydes/code/github/statick_ws/statick_venv/lib/python3.8/site-packages/statick_tool/statick.py", line 318, in run
    discovery_plugins = self.config.get_enabled_discovery_plugins(level)
  File "/home/axydes/code/github/statick_ws/statick_venv/lib/python3.8/site-packages/statick_tool/config.py", line 92, in get_enabled_discovery_plugins
    return self.get_enabled_plugins(level, "discovery")
  File "/home/axydes/code/github/statick_ws/statick_venv/lib/python3.8/site-packages/statick_tool/config.py", line 78, in get_enabled_plugins
    enabled_plugins = self.get_enabled_plugins(
  File "/home/axydes/code/github/statick_ws/statick_venv/lib/python3.8/site-packages/statick_tool/config.py", line 70, in get_enabled_plugins
    for level_type in self.config["levels"][level]:
KeyError: 'm'
(statick_venv) : ~/code/github/statick_ws/statick-web {main $%} $ statick . --output-directory /tmp/x --log info --user-paths ../gkogut-statick-md,../gkogut-statick-md/src/statick_md --profile md-profile.yaml --config md-config.yaml
INFO:root:Log level set to INFO
INFO:root:level: md_with_pylint
INFO:root:Writing output to: /tmp/x/statick-web-md_with_pylint
INFO:root:------
INFO:root:Scanning package statick-web (/home/axydes/code/github/statick_ws/statick-web) at level md_with_pylint
INFO:root:---Discovery---
INFO:root:Running markdown discovery plugin...

@denewiler
Copy link
Collaborator

LGTM. Updated config file fixes the issues for me as well.

@gregtkogut gregtkogut merged commit 810fbad into sscpac:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants