Use sedwards-lab/ssm library directly #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fibonacci example
… sort of regression test
…At this commit, runtime/include and runtime/src were soft-linked to their corresponding directories in sedwards-lab/ssm
…f the test cases begin to run
…mplify adding new variants for us
…hich we apparently forgot
…he init function to the platform
…refactor Rebase global references runtime refactor
- Use camel case for Haskell variables, e.g., global_references
- Use snake case for C symbols
- Deprecate `struct ssm_act *ssm_entry_point(..)` in favor of more
opaque `void ssm_initialize_program(..)`, which schedules the
entry point internally. This allows more flexibility in the
future for adjusting priorities for stuff like output handler
processes without having to coordinate with the tick driver.
|
Merging this into |
This was referenced Aug 5, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sedwards-lab very recently refactored the upstream runtime library at https://github.com/sedwards-lab/ssm . It simplifies my own refactor (on that repo's sched branch), which I had ported over earlier (in #30). The library is integrated into this repo as a git subtree (rather than the more common git submodule approach). This technique directly splices sedwards-lab/ssm's git history into this repo's history, so there isn't any need to do
git submodule initor anything of the sort. This should discourage invasive changes to the runtime library from here, but should the need to make changes arise, it's also possible to push only the commits from the runtime subdirectory back upstream.There's still a load of work to be done here, but I'm opening this PR now as a draft to document planned changes to existing components of this project. In particular:
ssm_as a prefix. A lot of other symbols are renamed too, following Stephen's changes.mainfunction is defined by the platform, which invokes whatever is pointed to byssm_entry_pointto kick off the SSM execution.At this time of writing, I'm still working on the event trace semantics, but I'm planning on logging the following events:
nowwill be)The value of all local variables upon entering and leaving the step function (how I'll handle uninitialized variables is not yet clear)Removing this for now because this saves me a little time fussing with uninitialized values and string formatting in C. That being said, we can easily distinguish by initialized vs uninitialized values by looking at thelast_updatedtimestamp. So it shouldn't be too hard, just more code.The former shall be logged in the generated code, while the latter two will be logged by the main loop driver of the trace platform.
At each step, the generated will increment a microtick that will be used bound non-terminating generated code.
Each event trace will also terminate with one of the following conditions (EDIT: see
ssm/SSM/Interpret/Trace.hsfor details):There may be a need for more event traces or terminal conditions, which I will discover as I proceed.