-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unsigned integers #78
Conversation
- Fix typo u32 -> u64 for representing LUInt64 - Use C long literals instead of putting in casts - Use signed representation when printing traces
@Rewbert fixed according to your suggestions, and ready for review! Now, there is one issue in #32 that remains to be addressed. This patch fixes the undefined behavior of signed integer over/underflow in C, but does not do anything to address the undefined behavior in Haskell. It so happens that on our current dev environment, Haskell's To fix that, should I fix the interpreter to perform arithmetic using |
I'd say skip for now, but leave the issue open :) |
Fix for #32 by using C's unsigned integers to represent SSM signed types.
Also includes some reorganization of
SSM.Backend.C
to isolate more of the type-related eccentricities withinSSM.Backend.C.Types
.