Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #14

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix unit tests #14

merged 2 commits into from
Oct 11, 2021

Conversation

j-hui
Copy link
Contributor

@j-hui j-hui commented Oct 11, 2021

This PR will fix the now-failing scanner and parser tests, and also set up a more extensible unit test suite for them.

@j-hui j-hui mentioned this pull request Oct 11, 2021
Open
sedwards-lab
sedwards-lab approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@sedwards-lab sedwards-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-hui j-hui marked this pull request as ready for review October 11, 2021 20:14
@j-hui j-hui merged commit f91dfa6 into main Oct 11, 2021
@j-hui j-hui deleted the fix-tests branch October 11, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedwards-lab sedwards-lab sedwards-lab approved these changes

@hmontero1205 hmontero1205 Awaiting requested review from hmontero1205

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-hui @sedwards-lab