Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for previewing several order types #54

Merged
merged 28 commits into from
Sep 27, 2021

Conversation

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #54 (e92d0d6) into master (ce4275a) will increase coverage by 2.79%.
The diff coverage is 76.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     73.15%   75.95%   +2.79%     
  Complexity       84       84              
============================================
  Files            21       24       +3     
  Lines          1453     1697     +244     
  Branches         80       90      +10     
============================================
+ Hits           1063     1289     +226     
- Misses          334      346      +12     
- Partials         56       62       +6     
Impacted Files Coverage Δ
src/main/kotlin/brokers/etrade/services/Orders.kt 51.11% <ø> (ø)
...rokers/etrade/services/orderPreview/CallOptions.kt 95.00% <ø> (ø)
src/main/kotlin/brokers/etrade/api/AccountsApi.kt 60.41% <48.14%> (-0.21%) ⬇️
...in/brokers/etrade/interceptors/ErrorInterceptor.kt 81.81% <50.00%> (-1.52%) ⬇️
...in/brokers/etrade/services/orderPreview/Condors.kt 78.12% <78.12%> (ø)
src/main/kotlin/brokers/etrade/api/AlertsApi.kt 97.72% <94.44%> (ø)
...in/brokers/etrade/services/orderPreview/Spreads.kt 96.42% <96.42%> (ø)
src/main/kotlin/brokers/etrade/api/MarketApi.kt 100.00% <100.00%> (ø)
src/main/kotlin/brokers/etrade/api/OrdersApi.kt 86.77% <100.00%> (+0.66%) ⬆️
src/main/kotlin/brokers/etrade/services/Service.kt 82.92% <100.00%> (+4.13%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4275a...e92d0d6. Read the comment docs.

@ssoper ssoper merged commit 7797441 into master Sep 27, 2021
@ssoper ssoper deleted the feature/preview-equities branch September 27, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant