-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyocera Default 'Message' App Support #475
Conversation
If setting is enabled, ignore DPAD_CENTER in Android MMS app to prevent double send.
Thanks for your contribution! Anyway, I think it may not be needed. I believe the problem is related to #393. I would like to fix that first and possibly reduce the number of hacks, including the double keycode sending, which causes problems on your phone. Would it be OK for you to test the fix for #393 once it is out, and only if you are still experiencing problems, then I'll consider merging your PR? |
There isn't one, but I am planing to fix that in the next release. |
Yes, I have been tracking this and am planning to test when I have some spare time. On Apr 16, 2024, at 02:50, Dimo Karaivanov ***@***.***> wrote:
@owentroe, I have done multiple improvements for the OK key, which I believe, have fixed the problem. The new v30.0 is officially out. Could you please try it out and report back if you are still having any issues?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@sspanak I just tested this (or at least the latest release in F droid), and the issue in the Kyocera messaging app still persists. However, I only see version 29.0 on f-droid when viewing through the f droid app on the phone. I see v30 on the browser f droid page. |
I managed to load v30, looks like it's working now (no double send bug). I will close this PR. |
This MR fixes behavior on the Kyocera DuraXA flip phone where sending a message with
DPAD_CENTER
results in a double send attempt, resulting in an error screen after each message is sent.A new app hack has been added to only send the
KEYCODE_DPAD_CENTER
event, and not attempt theKEYCODE_ENTER
code that is present inonEnterDefault()
. A toggle switch inside of the 'Initial Setup' menu has been added.I did not add menu strings for other (non-english) locales.