Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyocera Default 'Message' App Support #475

Closed

Conversation

owentroe
Copy link

This MR fixes behavior on the Kyocera DuraXA flip phone where sending a message with DPAD_CENTER results in a double send attempt, resulting in an error screen after each message is sent.

A new app hack has been added to only send the KEYCODE_DPAD_CENTER event, and not attempt the KEYCODE_ENTER code that is present in onEnterDefault(). A toggle switch inside of the 'Initial Setup' menu has been added.

I did not add menu strings for other (non-english) locales.

@sspanak
Copy link
Owner

sspanak commented Mar 25, 2024

Thanks for your contribution! Anyway, I think it may not be needed. I believe the problem is related to #393. I would like to fix that first and possibly reduce the number of hacks, including the double keycode sending, which causes problems on your phone.

Would it be OK for you to test the fix for #393 once it is out, and only if you are still experiencing problems, then I'll consider merging your PR?

@owentroe
Copy link
Author

Would it be OK for you to test the fix for #393 once it is out, and only if you are still experiencing problems, then I'll consider merging your PR?

Yeah, feel free to notify via this PR when ready. I didn't see an associated PR for issue #393, otherwise I could build and test sooner.

@sspanak
Copy link
Owner

sspanak commented Mar 25, 2024

Would it be OK for you to test the fix for #393 once it is out, and only if you are still experiencing problems, then I'll consider merging your PR?

Yeah, feel free to notify via this PR when ready. I didn't see an associated PR for issue #393, otherwise I could build and test sooner.

There isn't one, but I am planing to fix that in the next release.

@sspanak
Copy link
Owner

sspanak commented Mar 30, 2024

@owentroe, my attempt to fix the bug is ready to test. Could you please try v29.15? Alternatively, if you prefer building the APK on your own, just use the redo-ok branch.

Any feedback will be much appreciated!

@sspanak
Copy link
Owner

sspanak commented Apr 16, 2024

@owentroe, I have done multiple improvements for the OK key, which I believe, have fixed the problem. The new v30.0 is officially out. Could you please try it out and report back whether you are still having any issues?

@owentroe
Copy link
Author

owentroe commented Apr 17, 2024 via email

@owentroe
Copy link
Author

owentroe commented Apr 23, 2024

@sspanak I just tested this (or at least the latest release in F droid), and the issue in the Kyocera messaging app still persists.

However, I only see version 29.0 on f-droid when viewing through the f droid app on the phone. I see v30 on the browser f droid page.

@owentroe
Copy link
Author

I managed to load v30, looks like it's working now (no double send bug). I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants