Dockerize CSV2Avro #3
Conversation
| RUN mkdir -p /usr/src/app | ||
| WORKDIR /usr/src/app | ||
|
|
||
| COPY Gemfile* *.gemspec /usr/src/app/ |
There was a problem hiding this comment.
You should not use globs in the COPY commands and have individual steps for Gemfile, Gemfile.lock and csv2avro.gemspec. This will ensure that the intermediate steps can and will be cached. Probably most ideal would be:
COPY Gemfile /usr/src/app
COPY Gemfile.lock csv2avro.gemspec /usr/src/app
If this is valid.
|
@peterableda you should also add |
|
@rgabo Yes I know I should create a CMD but I got stuck with that. I haven't figured out how will I parametrize the cli. |
| @@ -8,7 +8,7 @@ options = {} | |||
| OPERATIONS = %w[convert] | |||
|
|
|||
| option_parser = OptionParser.new do |opts| | |||
| opts.banner = "Version #{CSV2Avro::VERSION} of CSV2Avro\n" \ | |||
| opts.banner = "Version 0.1.0avro of CSV2Avro\n" \ | |||
There was a problem hiding this comment.
I think the avro is unnecessary
There was a problem hiding this comment.
To be honest, I would not include the version number here. I've randomly checked json2csv, in2csv and sql2csv and none of them have a banner, just show usage.
There was a problem hiding this comment.
I checked a few too... q, avro-tools has a banner :D
No description provided.