Nested properties are not merged when doing a partial transform

[lukeshay]

When you pass a partial object to the transform field, the objects are not merged. For example, if you try to add an inline policy to a role, it does not get merged with the inline policies ion is adding. This is because the args and the transform object are spread and not merged. This line should do a deep merge and concat.

Example

sst.config.ts:

const table = new sst.aws.Table("Table");

// The inline policies array is overwritten so the policies that were added for the table are not there
new sst.aws.Function("Function", {
  link: [table],
  transform: {
    function: {
      tracingConfig: {
        mode: "Active",
      },
    },
    role: {
      inlinePolicies: [
        {
          name: "XRayPolicy",
          policy: $util.jsonStringify({
          Version: "2012-10-17",
            Statement: [
              {
                Effect: "Allow",
                Action: [
                  "xray:PutTraceSegments",
                  "xray:PutTelemetryRecords",
                ],
                Resource: "*",
              },
            ],
          }),
        },
      ],
    },
  },
});

[fwang]

hey @lukeshay

this should work:

new sst.aws.Function("Function", {
  transform: {
    role: (args) => {
      args.inlinePolicies.push({ ... });
    }
  }
});

i can see deep merge makes sense in this case, but it isn't ideal in other cases ie.

new sst.aws.Function("Function", {
  transform: {
    role: {
      architectures: ["arm64"]
    }
  }
});

the result architecture would've been both ["x86_64", "arm64"]

Feel free to reopen if u think current behavior isn't ideal.