Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading Ion/esbuild generated sourcemaps to Sentry #4432

Closed
paolostyle opened this issue Jul 15, 2024 · 5 comments
Closed

Uploading Ion/esbuild generated sourcemaps to Sentry #4432

paolostyle opened this issue Jul 15, 2024 · 5 comments
Assignees

Comments

@paolostyle
Copy link
Contributor

paolostyle commented Jul 15, 2024

So there is an article on how to do this in SST v2 but I don't think it has any use with Ion as there doesn't seem to be anything like hooks. I tried using Sentry's esbuild plugin but there were some cryptic error messages and then I found #4514 so I guess that's not an option. In general I'm looking for a way to generate the sourcemaps, not upload them to AWS during the deployment, and still be able to do something with them post-deployment (i.e. use the Sentry CLI).

@jayair
Copy link
Contributor

jayair commented Jul 19, 2024

I guess you could upload it as a part of your deployment process right?

@jayair jayair self-assigned this Jul 19, 2024
@paolostyle
Copy link
Contributor Author

Sure. I guess at the end of the day it's not that important to me when or how that happens, I just want to have it uploaded for every production release.

I still feel like providing a way to use esbuild plugins is the way to do it as Sentry's plugin does all the heavy lifting but if you have other ideas I'm all for it

@jayair
Copy link
Contributor

jayair commented Jul 26, 2024

Yeah we'll need to figure out a good way to allow for this.

@jayair
Copy link
Contributor

jayair commented Aug 21, 2024

Yeah I see. Let's look at the esbuild plugin issue here #4514

@jayair jayair closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@thdxr thdxr transferred this issue from sst/ion Oct 21, 2024
@andrewdoro
Copy link

I've started using SST to deploy my lambda functions. I want to upload the sourcemaps generated to Sentry.

I don't think this issue should be close. This is a common configuration for any production project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants