Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting all nodes of a Postgres construct when using .get() #4392

Closed
shmuli9 opened this issue Jul 22, 2024 · 1 comment
Closed

Allow getting all nodes of a Postgres construct when using .get() #4392

shmuli9 opened this issue Jul 22, 2024 · 1 comment
Assignees

Comments

@shmuli9
Copy link

shmuli9 commented Jul 22, 2024

When using sst.aws.Postgres..get() to get a pre-existing PG cluster, it only returns limited info about the cluster.

I think the get should return something as close as possible to instantiating a new Postgres so that the code to either create new or reuse existing Postgres infra can just be a drop in replacement with the the result of the .get() fn

I have a PR - https://github.com/sst/ion/pujll/693 - that (partially) addresses this

@fwang
Copy link
Contributor

fwang commented Jul 28, 2024

@shmuli9 I recently revamped how .get() work.

Previously sst.aws.Postgres.get() returned a PostgresRef instance. Now it returns an actual Postgres instance.

ie. You can access .nodes.instance.

@fwang fwang closed this as completed Jul 28, 2024
@thdxr thdxr transferred this issue from sst/ion Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants