This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Update documentation to warn people about Secret naming requirements #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this an error you got on deploy? |
|
Yes, that was literally the error message you get, but it's not mentioned in the documentation that their are any special requirements for secret names, so I assumed if it was a valid variable name it would work which is not the case. |
|
Yeah let me add it to the docs. The secret names follow the same rules as the components. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not mention the naming requirements for secrets, updating the documentation to reflect the error message you receive with an improperly named secret