A bunch of small improvements and fixes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before || was used that also forwards control for falsy values like an empty string and zero. ?? only does that for missing values (and nulls, but they are handled separately)
koskimas
force-pushed
the
various-fixes
branch
from
4cec1f6
to
4d726f5
Compare
|
Amazing thanks for this! All looks good to me - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I read through the code and spotted some places for improvement and some bugs. Feel free to pick whatever you like from this and throw away the rest. I may have also misunderstood some stuff.
There's a separate commit per change. The commit messages should explain the change.