This repository has been archived by the owner on Jun 10, 2018. It is now read-only.
Change to look for jsc in PATH so it will be found on most linux machines #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think I really want to support this. JSC is really messed up on OSX. I really won't be testing on linux. |
|
I understand, it's just really nice for me since a lot of systems have webkit's jsc already whereas hardly any already have nodejs and v8 installed, so this lets execjs work out of the box on more systems, right now I'm actually having problems on one system getting v8 to work either with node or therubyracer, jsc is all that does work :) |
|
Can you move jsc after the OS X path. |
josh
added a commit
that referenced
this pull request
Sep 2, 2011
Change to look for jsc in PATH so it will be found on most linux machines
ghost
mentioned this pull request
SamSaffron
pushed a commit
to SamSaffron/execjs
that referenced
this pull request
May 12, 2016
Allow for runtime specific option flags
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find jsc when it is in your PATH so it can be used on linux as well as osx.
Recently found myself wanting to use webkit's jsc on linux :)