Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller to transform and forward commands #555

Closed
3 of 5 tasks
ssube opened this issue Oct 19, 2019 · 0 comments · Fixed by #560
Closed
3 of 5 tasks

controller to transform and forward commands #555

ssube opened this issue Oct 19, 2019 · 0 comments · Fixed by #560
Assignees
Labels
scope/controller status/fixed issues that have been fixed and confirmed type/feature
Milestone

Comments

@ssube
Copy link
Owner

ssube commented Oct 19, 2019

Summary

Triggering one command because of another command (or message) is the last major component to self-updating (#313, #544). This controller has a few needs, met by existing services:

  • conditional execution, handled by filters
  • payload modification, handled by transforms

Thanks to that existing code, the only new functionality in this is a controller is executing a new command.

Scope

  • figure out appropriate name
  • execute-command controller
  • docs
  • schema
  • tests

Use Case

  • approving an MR/PR after receiving check status, excluding WIP:
  • merging an MR/PR after receiving approval, based on author
@ssube ssube added this to the 1.0 - stable milestone Oct 19, 2019
@ssube ssube self-assigned this Oct 19, 2019
@ssube ssube mentioned this issue Oct 19, 2019
9 tasks
@ssube ssube added scope/controller status/progress issues that are in progress and removed status/new labels Oct 19, 2019
@ssube ssube mentioned this issue Oct 20, 2019
@isolex isolex bot closed this as completed in #560 Oct 20, 2019
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/progress issues that are in progress labels Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/controller status/fixed issues that have been fixed and confirmed type/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant