Improve setup.py #23
Merged
Improve setup.py #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now setup.py don't import googletrans.__init__.py wchich import requests, and this occure ImportError during installation of library. * Changes with getting version in setup.py without importing googletrans.__init__.py Now you can install py-googletrans on clean virtualenv, without earlier install dependencies.
ghost
mentioned this pull request
|
I'm really sorry that I didn't catch this before. I'm going to merge this, and I really appreciate your work. Thanks! |
|
@ssut Thank you very much. Can you please also bump version? Because pip will be cached 2.1.2 |
|
@mariusz-korzekwa Yes sure, just give me a few moments, I'll bump a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to change the way of getting version number and doc string in setup.py, that we do not have to import init.py to setup.py.
In my fork, I create the way of getting version number without import another files of googletrans library. I open init.py file read it and get version and doc string with regex.
This method is used by many big libraries, ex. django-rest-framework.
@ssut please consider this solution, because it can help many people.