Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pectra ready (deposit amount 32 to 2048 ETH) #9

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

pavelkrolevets
Copy link
Contributor

Ethereum going to change deposit amount to allow it in range 32 to 2048 ETH eip7251

  • updated init, resign, reshare types to include amount
  • update add checks for amount range from 32 to 2048 eth
  • use amount to create deposit sigs + validation

init.go Show resolved Hide resolved
Copy link
Contributor

@MatusKysel MatusKysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add tests for invalid amount sets for each case (below and above threshold) in init, resign and reshare (if reshare is necessary)

types.go Show resolved Hide resolved
Copy link
Contributor

@alan-ssvlabs alan-ssvlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatusKysel MatusKysel merged commit 40e39a7 into ssvlabs:master Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants