Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vc/potential stage fix #78

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Vc/potential stage fix #78

merged 1 commit into from
Jan 18, 2024

Conversation

vadiminc
Copy link
Contributor

No description provided.

@vadiminc vadiminc changed the base branch from main to stage January 18, 2024 15:10
@@ -10,7 +10,7 @@ import { SSVLiquidatorException } from '@cli/exceptions/base';

@Injectable()
export class LiquidationTask {
private static isProcessLocked = false;
public static isProcessLocked = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected?

const latestBlockNumber =
await this._web3Provider.web3.eth.getBlockNumber();
const latestBlockNumber =
+(await this._web3Provider.web3.eth.getBlockNumber());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this casting really necessary? according to web3 docs this call returns Number

@vadiminc vadiminc merged commit 1b4a60d into stage Jan 18, 2024
@vadiminc vadiminc deleted the vc/potential-stage-fix branch January 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants