New slot ticker #1149
Merged
New slot ticker #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
force-pushed
the
new-slot-ticker
branch
2 times, most recently
from
d506b83
to
ed37f67
Compare
MatusKysel
force-pushed
the
new-slot-ticker
branch
from
ed37f67
to
a56770c
Compare
MatusKysel
force-pushed
the
new-slot-ticker
branch
from
a56770c
to
10cbf6e
Compare
MatusKysel
force-pushed
the
new-slot-ticker
branch
2 times, most recently
from
66b02e8
to
5ff3421
Compare
MatusKysel
force-pushed
the
new-slot-ticker
branch
from
5ff3421
to
a12d39b
Compare
nkryuchkov
reviewed
Sep 25, 2023
nkryuchkov
previously approved these changes
Sep 25, 2023
MatusKysel
force-pushed
the
new-slot-ticker
branch
from
7b07dab
to
a248afa
Compare
nkryuchkov
previously approved these changes
Sep 25, 2023
y0sher
reviewed
Sep 26, 2023
y0sher
reviewed
Sep 26, 2023
y0sher
reviewed
Sep 26, 2023
nkryuchkov
reviewed
Sep 26, 2023
moshe-blox
requested changes
Oct 4, 2023
nkryuchkov
previously approved these changes
Oct 4, 2023
y0sher
previously approved these changes
Oct 5, 2023
MatusKysel
force-pushed
the
new-slot-ticker
branch
2 times, most recently
from
7150604
to
faa6416
Compare
MatusKysel
force-pushed
the
new-slot-ticker
branch
from
faa6416
to
6b35ba3
Compare
moshe-blox
approved these changes
Oct 10, 2023
nkryuchkov
approved these changes
Oct 10, 2023
| "github.com/bloxapp/ssv/protocol/v2/types" | ||
| ) | ||
|
|
||
| //go:generate mockgen -package=mocks -destination=./mocks/scheduler.go -source=./scheduler.go | ||
|
|
||
| var slotDelayHistogram = promauto.NewHistogram(prometheus.HistogramOpts{ | ||
| Name: "slot_ticker_delay_milliseconds", |
There was a problem hiding this comment.
According to Prometheus naming guidelines:
...must have a single unit (i.e. do not mix seconds with milliseconds, or seconds with bytes).
...should use base units (e.g. seconds, bytes, meters - not milliseconds, megabytes, kilometers). See below for a list of base units.
Also, other metrics in the project use the _seconds suffix, so we might need to consider making them consistent. On the other hand, I don't foresee any issues if we don't change it. So this is rather a suggestion, not a change request.
nkryuchkov
reviewed
Oct 10, 2023
y0sher
added a commit
that referenced
this pull request
Oct 15, 2023
* Message validation (#1066) --------- Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> * e2e tests for eth execution layer package (#1143) * New slot ticker (#1149) --------- Co-authored-by: Matus Kysel <matus@Matuss-MacBook-Air.local> Co-authored-by: moshe-blox <moshe@blox.io> --------- Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> Co-authored-by: Anton Korpusenko <antokorp@gmail.com> Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com> Co-authored-by: Matus Kysel <matus@Matuss-MacBook-Air.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feed-less, gorountine-less slot ticker that is based on golang Timer