RSA message encryption #1190
Merged
RSA message encryption #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nkryuchkov
commented
Nov 1, 2023
•
nkryuchkov
commented
- BLS verification is replaced with RSA verification in message validation
- SSVMessage is wrapped in another type with RSA signature and operator ID
- Minor message validation cleanup
- Flags for signature checks are removed from message validation
- Tests for RSA in message validation
- Tests for RSA sign/verify
- Benchmarks for RSA & BLS sign & verify
This reverts commit 9658443.
y0sher
previously approved these changes
Nov 8, 2023
MatheusFranco99
previously approved these changes
Nov 8, 2023
MatusKysel
previously approved these changes
Nov 8, 2023
moshe-blox
requested changes
Nov 9, 2023
|
|
||
| // ConsensusState keeps track of the signers for a given public key and role. | ||
| type ConsensusState struct { | ||
| // TODO: consider evicting old data to avoid excessive memory consumption |
There was a problem hiding this comment.
@y0sher @nkryuchkov eviction should probably be done in the parent map which holds all ConsensusState instances, because it'd also evict this and the map keys there have far higher # of combinations (Pubkey + Role vs just OperatorID)
nkryuchkov
dismissed stale reviews from MatusKysel, MatheusFranco99, and y0sher
via
2fa62cc
nkryuchkov
requested review from
moshe-blox,
MatheusFranco99,
y0sher and
MatusKysel
MatusKysel
previously approved these changes
Nov 9, 2023
moshe-blox
previously approved these changes
Nov 9, 2023
MatheusFranco99
previously approved these changes
Nov 9, 2023
y0sher
previously approved these changes
Nov 9, 2023
nkryuchkov
dismissed stale reviews from y0sher, MatheusFranco99, moshe-blox, and MatusKysel
via
33d1d4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.