fix: stale operator ID in p2pNetwork
#1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.2.1: Permission Fork Schedule for Mainnet
y0sher
approved these changes
Dec 6, 2023
nkryuchkov
approved these changes
Dec 6, 2023
| @@ -63,7 +63,7 @@ type Config struct { | |||
| // OperatorPubKeyHash is hash of operator public key, used for identity, optional | |||
| OperatorPubKeyHash string | |||
| // OperatorID contains numeric operator ID | |||
| OperatorID spectypes.OperatorID | |||
| OperatorID func() spectypes.OperatorID | |||
There was a problem hiding this comment.
Please update comment.
Also, I'd consider renaming to something like OperatorIDFunc/OperatorIDF/GetOperatorID/OperatorIDGetter to explicitly show that this is not a number
There was a problem hiding this comment.
@Tomblox1 monday ticket for this could help us rememebr.
There was a problem hiding this comment.
moshe-blox
added a commit
that referenced
this pull request
Dec 6, 2023
* fix: stale operator ID in `p2pNetwork` --------- Co-authored-by: Lior Rutenberg <liorr@blox.io>
moshe-blox
added a commit
that referenced
this pull request
Jan 2, 2024
* fix: stale operator ID in `p2pNetwork` (#1229) * fix: stale operator ID in `p2pNetwork` --------- Co-authored-by: Lior Rutenberg <liorr@blox.io> * fix: sufficient timeout for initial duty fetch (#1214) * fix: sufficient timeout for initial duty fetch (#1214) --------- Co-authored-by: Matus Kysel <matus@blox.io> * deployment: change bootnode for holesky-stage (#1233) * deploy new bootnode ENR for holesky stage * Voluntary exit (#1200) * Voluntary exit --------- Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: olegshmuelov <oleg@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> * feat: include 'connected' in peer scores log (#1224) * feat: include 'connected' in peer scores log * P2P metrics (#1163) * metrics: added p4 score (invalidMessageDeliveries) * metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification * deploy to the stage # Conflicts: # .gitlab-ci.yml * metrics: added counters flush once in 8h * metrics: added counters for duties * Added auto delete disconnected peers label metrics. Added RSA verifications metric * disabled ci * Updated p4 score metric update * metrics: added p4 score (invalidMessageDeliveries) * metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification * deploy to the stage # Conflicts: # .gitlab-ci.yml * metrics: added counters flush once in 8h * metrics: added counters for duties * Added auto delete disconnected peers label metrics. Added RSA verifications metric * disabled ci * Updated p4 score metric update * review comments fixes * deploy * deploy * testing metrics differ * added duties created and finalized * removed extra monitoring.metricsreporter usage * removed topic from p4score. made it a sum of squares * deploy to all nodes * deploy p2p_metrics * pr review fixes * trigger ci * deploy 9-20 * Fix msg validation rsa verification counter metric * allocate p2p_metrics * inspect scores more frequently, but don't log every time * renamed duties created/finalized metrics and refactored to record role * deploy to 5--8 * deploy to 5--8 * rename metric * blank space * approve spec change (just a metric) * refactors * reset scores * metric help msg * revert gitlab * deploy * revert deploy * Add metrics for signature verifications * Update differ.config.yaml with approved changes --------- Co-authored-by: Anton Korpusenko <anton@blox.io> Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> Co-authored-by: moshe-blox <moshe@blox.io> * Node health (#1203) * chore: link to SSV API docs in configs & README * initial commit * add node health route to ssv API * update health route * update health route * update health route * update health route * deploy to stage * add plaintext response * lint * lint * change to good/bad * lint * lint * refactor * Revert "deploy to stage" This reverts commit 2f54f4e. * lint * add inbound/outbound count for health + deploy to stage * change ports back * update count * lint * update conns * lint * remove connected peer count * test blocked ports * Revert "remove connected peer count" This reverts commit 79e2b94. * leave only active peers count * Revert "test blocked ports" This reverts commit 6fc9282. * ci to stage * add mutex to nodes access * refactor: node health API (#1222) * refactor: node health API * added cpu_cores to healthcheck output * fix inbound/outbound stats * Remove CPU core reporting --------- Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> * feat: subscribe to a random subnet with 0 validators (#1245) * feat: subscribe to a random subnet with 0 validators * Fix: health route host addres (#1246) * node health api route advertises the host addresses from the config. * set up listenaddress directly * feat: rate limit inbound connections by IP (#1226) * feat: rate limit inbound connections by IP * activate conngater * deploy to 5--8 * fix * fix * Refactor connection gating in p2p setup * Update ipLimiter parameters * revert gitlab * Revert "revert gitlab" This reverts commit fcc7902. * Revert "Revert "revert gitlab"" This reverts commit feb9e4e. --------- Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> --------- Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> Co-authored-by: Lior Rutenberg <liorr@blox.io> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: olegshmuelov <oleg@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> Co-authored-by: Anton Korpusenko <antokorp@gmail.com> Co-authored-by: Anton Korpusenko <anton@blox.io> Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com>
y0sher
added a commit
that referenced
this pull request
Jul 28, 2024
* fix: stale operator ID in `p2pNetwork` (#1229) (#1230) * fix: stale operator ID in `p2pNetwork` --------- Co-authored-by: Lior Rutenberg <liorr@blox.io> * v1.2.2 (#1248) * fix: stale operator ID in `p2pNetwork` (#1229) * fix: stale operator ID in `p2pNetwork` --------- Co-authored-by: Lior Rutenberg <liorr@blox.io> * fix: sufficient timeout for initial duty fetch (#1214) * fix: sufficient timeout for initial duty fetch (#1214) --------- Co-authored-by: Matus Kysel <matus@blox.io> * deployment: change bootnode for holesky-stage (#1233) * deploy new bootnode ENR for holesky stage * Voluntary exit (#1200) * Voluntary exit --------- Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: olegshmuelov <oleg@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> * feat: include 'connected' in peer scores log (#1224) * feat: include 'connected' in peer scores log * P2P metrics (#1163) * metrics: added p4 score (invalidMessageDeliveries) * metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification * deploy to the stage # Conflicts: # .gitlab-ci.yml * metrics: added counters flush once in 8h * metrics: added counters for duties * Added auto delete disconnected peers label metrics. Added RSA verifications metric * disabled ci * Updated p4 score metric update * metrics: added p4 score (invalidMessageDeliveries) * metrics: added total msgs accepted, msgs accepted from peer with Id, signatures verification * deploy to the stage # Conflicts: # .gitlab-ci.yml * metrics: added counters flush once in 8h * metrics: added counters for duties * Added auto delete disconnected peers label metrics. Added RSA verifications metric * disabled ci * Updated p4 score metric update * review comments fixes * deploy * deploy * testing metrics differ * added duties created and finalized * removed extra monitoring.metricsreporter usage * removed topic from p4score. made it a sum of squares * deploy to all nodes * deploy p2p_metrics * pr review fixes * trigger ci * deploy 9-20 * Fix msg validation rsa verification counter metric * allocate p2p_metrics * inspect scores more frequently, but don't log every time * renamed duties created/finalized metrics and refactored to record role * deploy to 5--8 * deploy to 5--8 * rename metric * blank space * approve spec change (just a metric) * refactors * reset scores * metric help msg * revert gitlab * deploy * revert deploy * Add metrics for signature verifications * Update differ.config.yaml with approved changes --------- Co-authored-by: Anton Korpusenko <anton@blox.io> Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> Co-authored-by: moshe-blox <moshe@blox.io> * Node health (#1203) * chore: link to SSV API docs in configs & README * initial commit * add node health route to ssv API * update health route * update health route * update health route * update health route * deploy to stage * add plaintext response * lint * lint * change to good/bad * lint * lint * refactor * Revert "deploy to stage" This reverts commit 2f54f4e. * lint * add inbound/outbound count for health + deploy to stage * change ports back * update count * lint * update conns * lint * remove connected peer count * test blocked ports * Revert "remove connected peer count" This reverts commit 79e2b94. * leave only active peers count * Revert "test blocked ports" This reverts commit 6fc9282. * ci to stage * add mutex to nodes access * refactor: node health API (#1222) * refactor: node health API * added cpu_cores to healthcheck output * fix inbound/outbound stats * Remove CPU core reporting --------- Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> * feat: subscribe to a random subnet with 0 validators (#1245) * feat: subscribe to a random subnet with 0 validators * Fix: health route host addres (#1246) * node health api route advertises the host addresses from the config. * set up listenaddress directly * feat: rate limit inbound connections by IP (#1226) * feat: rate limit inbound connections by IP * activate conngater * deploy to 5--8 * fix * fix * Refactor connection gating in p2p setup * Update ipLimiter parameters * revert gitlab * Revert "revert gitlab" This reverts commit fcc7902. * Revert "Revert "revert gitlab"" This reverts commit feb9e4e. --------- Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> --------- Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> Co-authored-by: Lior Rutenberg <liorr@blox.io> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: olegshmuelov <oleg@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> Co-authored-by: Anton Korpusenko <antokorp@gmail.com> Co-authored-by: Anton Korpusenko <anton@blox.io> Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com> * Revert "v1.2.2 (#1248)" (#1263) This reverts commit ff2f594. * chore: fix some function names Signed-off-by: linghuying <1599935829@qq.com> --------- Signed-off-by: linghuying <1599935829@qq.com> Co-authored-by: Lior Rutenberg <liorr@blox.io> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> Co-authored-by: rehs0y <lyosher@gmail.com> Co-authored-by: Matus Kysel <matus@blox.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: moshe-blox <moshe@blox.io> Co-authored-by: olegshmuelov <oleg@blox.io> Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> Co-authored-by: Anton Korpusenko <antokorp@gmail.com> Co-authored-by: Anton Korpusenko <anton@blox.io> Co-authored-by: Gal Rogozinski <galrogogit@gmail.com> Co-authored-by: Pavel Krolevets <pavelkrolevets@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a post-fork bug found with @y0sher