Pubsub Scoring (WIP) #700
Merged
Pubsub Scoring (WIP) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirylm
force-pushed
the
scoring
branch
4 times, most recently
from
83b8201
to
73f409e
Compare
- added topic scoring - aligned global scoring params with ETH
aligned with https://gist.githubusercontent.com/blacktemplar/5c1862cb3f0e32a1a7fb0b25e79e6e2c/raw/1e9e322b21adcb657bea3596ea2deb19f319f707/generate-scoring-params.py to have a more clean code strcuture and flexibility w.r.t checking and testing scoring params TODO: remove old code
amirylm
added a commit
that referenced
this pull request
Sep 15, 2022
* topic score params for decided and subnets (WIP) * set coring flag to true by default * fixes and score inspect logs * add metric for scores * align scoring params and log errors * expose active validators for scoring params * change peer identities reporting interval * pubsub tracer: add reason in reject message * refactor scoring params aligned with https://gist.githubusercontent.com/blacktemplar/5c1862cb3f0e32a1a7fb0b25e79e6e2c/raw/1e9e322b21adcb657bea3596ea2deb19f319f707/generate-scoring-params.py to have a more clean code strcuture and flexibility w.r.t checking and testing scoring params * params package for managing pubsub params * rename vars, clean scores metric every hour * clean metrics
amirylm
added a commit
that referenced
this pull request
Sep 21, 2022
* topic score params for decided and subnets (WIP) * set coring flag to true by default * fixes and score inspect logs * add metric for scores * align scoring params and log errors * expose active validators for scoring params * change peer identities reporting interval * pubsub tracer: add reason in reject message * refactor scoring params aligned with https://gist.githubusercontent.com/blacktemplar/5c1862cb3f0e32a1a7fb0b25e79e6e2c/raw/1e9e322b21adcb657bea3596ea2deb19f319f707/generate-scoring-params.py to have a more clean code strcuture and flexibility w.r.t checking and testing scoring params * params package for managing pubsub params * rename vars, clean scores metric every hour * clean metrics
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pubsub scoring capabilities based on ETH 2 config set (see code to generate) with some changes to adapt to the size and number of messages in our topics.
Note that scoring of message validation is not active at the moment, will be added with the validation epic.
Including the following changes:
paramspackage to manage all pubsub related params (scoring + thresholds and gossipsub)TODO fine tune peer and topic scoring params to identify misbehaving peers