Spec Alignment: Decided Sync #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirylm
commented
Nov 9, 2022
amirylm
commented
Nov 9, 2022
| } | ||
| return msg, nil | ||
| err = c.GetConfig().GetStorage().SaveHighestDecided(msg) | ||
| return msg, errors.Wrap(err, "could not save highest decided") |
There was a problem hiding this comment.
avoid returning error
amirylm
commented
Nov 9, 2022
TODO: uncomment once we support processing of sync messages (consensus while instance is not running)
+ added logs
TODO: resolve in a different way
amirylm
force-pushed
the
spec-align-qbft-sync
branch
from
5c93198
to
1a72ae3
Compare
liorrutenberg
pushed a commit
that referenced
this pull request
Feb 1, 2023
* ShifuV2 genesis epoch (#820) Epoch 156113 * shifuv-v2 new network 156113 (#832) * Align to spec to 0.2.9 * Passing spec tests * Introduced protocol logger * Upgrade to key manager v1.2.0 (use goclient instead of prysm objects) * Remove exporter leftovers (#722) * Fix round state names (#727) * Avoid delay on every check for peers (#732) * Spec Alignment: Decided Sync (#734) * Extract metadata from share, use spec share (#735) * Move Share and Metadata into a new SSVShare struct * Spec alignment: Change Round (#740) * Patched changes from spec: * ssvlabs/ssv-spec#100 * ssvlabs/ssv-spec#105 * ssvlabs/ssv-spec#109 * Align instance container (#739) * Deprecate v1 (#743) * Local events (shares) (#745) * Spec alignment: Validator Refactoring (#748) * Add metrics for attestation submission and message processing durations (#736) * Non committee validator post spec align (#751) * Store highest instance instead of highest decided (#752) * Deprecate ToMessageID Func (#757) * CI: spec testing (#758) * Constant round duration (#756) * Deprecate SyncHighestRound * Deprecate SSVDecidedMsgType * Allow override min genesis time to support custom testnets * Revised logging (#768) * Protocol packages utils restructuring (#766) * Pubsub: fix topics management (#773) * Create a regular simulation (#772) * Multi duties (#777) * add graffiti to share + migration * Upgrade go (1.19) and libp2p (v0.24) (#789) * Event Based msg (#791) * Round timer as an event in the queue * Duty execution as an event in the queue * eth2client interface (#794) * TimeoutF To Runner (#797) * Streams Deadline (#792) * Fee Recipient (#795) * Round change & f+1 decided integration tests; validation functions (#793) * Round change integration test * F+1 decided integration test * Slashing protection (#805) * Minimal slashing protection (#807) * Node cli cleanup (#812) * New Msg Q (#801) * #761 * Full node (#785) * Happy flow 7 and 10 committee + integration test stabilisation (#810) --------- Co-authored-by: Lior Rutenberg <liorr@blox.io> Co-authored-by: Amir Yahalom <amir@blox.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com> Co-authored-by: olegshmuelov <45327364+olegshmuelov@users.noreply.github.com> Co-authored-by: moshe-blox <89339422+moshe-blox@users.noreply.github.com> Co-authored-by: Yehor Sereda <yehor@blox.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides changes that were taken from ssvlabs/ssv-spec#94, the following changes are included:
synctype in the following PRs)