Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move excluding fields logic into serializers [fixes #96] #138

Merged
merged 1 commit into from
Jan 17, 2021
Merged

Move excluding fields logic into serializers [fixes #96] #138

merged 1 commit into from
Jan 17, 2021

Conversation

st4lk
Copy link
Owner

@st4lk st4lk commented Jan 17, 2021

No description provided.

@st4lk st4lk mentioned this pull request Jan 17, 2021
Merged
@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.9%) to 41.401% when pulling 00b3a5d on move-excluding-fields-logic-into-serializer into b70e7cc on master.

@st4lk st4lk merged commit f8ee74b into master Jan 17, 2021
@st4lk st4lk deleted the move-excluding-fields-logic-into-serializer branch January 17, 2021 11:49
aalekhpatel07
aalekhpatel07 reviewed Jan 20, 2021
View reviewed changes
Copy link

@aalekhpatel07 aalekhpatel07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model = get_user_model() declaration remains unused. Recommend replacing get_user_model() in Line 33 with model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalekhpatel07 aalekhpatel07 aalekhpatel07 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st4lk @coveralls @aalekhpatel07