Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RecordingQueryReflector for prepared statements #79

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Conversation

staabm
Copy link
Owner

@staabm staabm commented Jan 11, 2022

No description provided.

@staabm staabm changed the title fix RecordingQueryReflector for prepared statements fix RecordingQueryReflector for prepared statements Jan 11, 2022
Comment on lines -67 to -70
// atm we just make sure, this is not detected as a syntax error.
// a proper return type check should be added in the future.
$pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=?', PDO::FETCH_ASSOC);
$pdo->query('SELECT email, adaid, gesperrt, freigabe1u1 FROM ada WHERE adaid=:adaid', PDO::FETCH_ASSOC);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have proper coverage for this cases already in pdo-stmt-execute.php

@staabm staabm merged commit 135690e into main Jan 11, 2022
@staabm staabm deleted the prep-fix branch January 11, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants