Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proj:epsg is marked as "required", but this only applies to items #7

Closed
l0b0 opened this issue Oct 8, 2021 · 11 comments · Fixed by #15
Closed

proj:epsg is marked as "required", but this only applies to items #7

l0b0 opened this issue Oct 8, 2021 · 11 comments · Fixed by #15
Assignees
Labels
bug Something isn't working

Comments

@l0b0
Copy link

l0b0 commented Oct 8, 2021

The readme says proj:epsg is required, but it's only actually required inside items. Is this a bug in the schema, a missing piece of documentation, or have I misunderstood something?

@m-mohr
Copy link
Contributor

m-mohr commented Dec 11, 2021

Yes, I think it is only required in items, indeed.

@vincentsarago
Copy link

if I understand well, proj:epsg is required in the item OR the asset property. Not sure how to translate this in the schema 😬

@m-mohr m-mohr added the bug Something isn't working label Jul 6, 2022
@m-mohr
Copy link
Contributor

m-mohr commented Jul 6, 2022

I've also recently struggled with the schema issue, so putting this on my to do list...

@m-mohr m-mohr self-assigned this Jul 6, 2022
@Kirill888
Copy link
Contributor

Kirill888 commented Jul 11, 2022

Just came across this issue when running validator.

What happens when you use proj:wkt2 with some projection without an EPSG code? In my case it's MODIS.

I'd say it should be "at least one of proj:epsg, proj:wkt2, proj:projjson should be present", not sure how that can be expressed in json schema.

EDIT: so I guess I need to set it to null? #6

@m-mohr
Copy link
Contributor

m-mohr commented Jul 11, 2022

Yeah, it was meant to be that you set proj:epsg to null if you specify a WKT2 or PROJJSON that has no corresponding EPSG code.

The issue that the schema has is that it always requires this for the item properties although it could be present either there or in one of the other places (assets, etc:)

We need to find someone who has the time to do these changes though.

@Kirill888
Copy link
Contributor

Kirill888 commented Jul 11, 2022

"required" but can/should be set to null is a bit confusing to be honest. In my case it turns out pgstac is stripping nulls when hydrating items out of db, so can't produce compliant stac item out of the API even after updating generation logic :(.

@m-mohr
Copy link
Contributor

m-mohr commented Oct 24, 2022

Dev call: Remove the requirement for proj:epsg

Afterthoughts: What do the null values for the CRS fields then mean? Usually, we just omit them instead of allowing null, so feels a bit inconsistent...

@tschaub
Copy link
Contributor

tschaub commented Feb 2, 2023

Does anyone know how clients will interpret "proj:epsg": null on the item properties and a non-null value on the assets? I'm hoping to find a way to have metadata that validates with the current schema and works with existing clients. In my case, some of the assets are metadata files, so it doesn't necessarily make sense to have proj:epsg at the item property level.

@m-mohr
Copy link
Contributor

m-mohr commented Feb 2, 2023

@tschaub I'll fix this asap. Forgot a bit about it, but will make sure we release a version without the epsg requirement soon.

@m-mohr
Copy link
Contributor

m-mohr commented Feb 3, 2023

Oh and to specifically answer your question: All clients I've seen so far and it's also the rule in STAC in general that Asset properties override general Item properties.

@m-mohr m-mohr closed this as completed in #15 Feb 7, 2023
m-mohr added a commit that referenced this issue Feb 7, 2023
* Add more examples, clarify/fix `proj:epsg` requirement #7, align repo with template

* Don't require proj:epsg as discussed in the STAC meeting

* Clarification

* Recommendation around thumbnails

* Update README.md

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>

---------

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@m-mohr
Copy link
Contributor

m-mohr commented Feb 10, 2023

This has finally been fixed. You don't need to provide proj:epsg at the item level any longer.

jlaura pushed a commit to jlaura/projection that referenced this issue Apr 3, 2023
* Add more examples, clarify/fix `proj:epsg` requirement stac-extensions#7, align repo with template

* Don't require proj:epsg as discussed in the STAC meeting

* Clarification

* Recommendation around thumbnails

* Update README.md

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>

---------

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
jlaura pushed a commit to jlaura/projection that referenced this issue Apr 3, 2023
* Add more examples, clarify/fix `proj:epsg` requirement stac-extensions#7, align repo with template

* Don't require proj:epsg as discussed in the STAC meeting

* Clarification

* Recommendation around thumbnails

* Update README.md

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>

---------

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants