Remove default eo:cloud_cover queryable #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default queryable was added in the early days of pgstac so that the field would be indexed by default if it was present in any items. However, now that the queryables table is used to generate content for /queryables stac endpoint, it is included in the queryable content for all collections (since there is no collection_id). Removing this opmtimization fixes incorrect (and broken, since the $ref url also has a typo) default behavior.
bitner
force-pushed
the
mjm/remove-default-queryable-cc
branch
from
7a70e98
to
ed2af02
Compare
bitner
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default queryable was added in the early days of pgstac so that the field would be indexed by default if it was present in any items. However, now that the queryables table is used to generate content for
/queryablesstac endpoint in stac-fastapi, it is included in the queryable content for all collections (since there is nocollection_id).Removing this optimization fixes incorrect (and broken, since the $ref URL also has a typo) default behavior.