Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.items datetime is timestamp without time zone #100

Closed
bitner opened this issue Mar 1, 2021 · 2 comments · Fixed by #102
Closed

data.items datetime is timestamp without time zone #100

bitner opened this issue Mar 1, 2021 · 2 comments · Fixed by #102

Comments

@bitner
Copy link
Collaborator

bitner commented Mar 1, 2021

Timestamp without time zone should always be avoided as it is ambiguous as to the timezone represented by the field and can be lossy at the DST transition time.
@kylebarron
Copy link
Contributor

Since the STAC spec defines timestamps as always being in UTC, is it still necessary to store the timezone? https://github.com/radiantearth/stac-spec/blob/4988a40f6071666d345e4a1c5adc9a6338973769/item-spec/item-spec.md#properties-object

@bitner
Copy link
Collaborator Author

bitner commented Mar 1, 2021

yes. :-) IMHO there is very little reason to ever use the timestamp without time zone type in Postgres. If it costs nothing to be explicit you should always be explicit and thus ensure the database will do the right thing.

bitner pushed a commit to bitner/stac-fastapi that referenced this issue Mar 2, 2021
@geospatial-jeff @bitner
change datetime field to use timestamp with timezone (stac-utils#100)
00d26ab
bitner added a commit to bitner/stac-fastapi that referenced this issue Mar 2, 2021
@bitner
change datetime field to use timestamptz (stac-utils#100)
d9115a5
@bitner bitner mentioned this issue Mar 2, 2021
Merged
bitner added a commit to bitner/stac-fastapi that referenced this issue Mar 2, 2021
@bitner
change datetime field to use timestamptz (stac-utils#100)
bcc9b5b 
linting

install pre-commit so I actually do ALL the expected linting

uggh difference in black line length
geospatial-jeff pushed a commit that referenced this issue Mar 2, 2021
@bitner
change datetime field to use timestamptz (#100) (#102)
6f7f342 
linting

install pre-commit so I actually do ALL the expected linting

uggh difference in black line length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change datetime field to use timestamptz (#100) bitner/stac-fastapi
2 participants
@bitner @kylebarron