Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for beta.4 changes #104

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Conversation

moradology
Copy link
Collaborator

@moradology moradology commented Nov 16, 2021

The only relevant bit of beta.4 for stac-pydantic appears to be the addition of a canonical and service-doc relation types for links, this PR adds that

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #104 (1ea8161) into master (cdd0550) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   96.19%   96.20%           
=======================================
  Files          20       20           
  Lines         473      474    +1     
=======================================
+ Hits          455      456    +1     
  Misses         18       18           
Flag Coverage Δ
unittests 96.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stac_pydantic/links.py 98.24% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd0550...1ea8161. Read the comment docs.

Copy link

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- might want to mention service-doc inclusion as well in PR description, and add a changelog

@moradology moradology merged commit 6cce2fa into stac-utils:master Nov 22, 2021
@moradology moradology deleted the feature/beta4 branch November 22, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants