Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename type_ to r#type on asset #68

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Rename type_ to r#type on asset #68

merged 3 commits into from
Apr 26, 2022

Conversation

gadomski
Copy link
Member

Closes

Description

Renames type_ to type on asset to bring it into alignment with the rest of the structures.

Checklist

  • Git history is linear
  • Commit messages are descriptive
  • (optional) Git commit messages follow conventional commits
  • Code is formatted (cargo fmt)
  • cargo test
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #68 (92ff5d2) into main (1839467) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files          17       17           
  Lines        1374     1374           
  Branches      350      350           
=======================================
  Hits          892      892           
  Misses        183      183           
  Partials      299      299           
Impacted Files Coverage Δ
src/asset.rs 48.48% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1839467...92ff5d2. Read the comment docs.

@gadomski gadomski added this to the v0.0.5 milestone Apr 26, 2022
@gadomski gadomski merged commit 675f65a into main Apr 26, 2022
@gadomski gadomski deleted the issues/65-rename-type branch April 26, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename type_ to r#type in Asset
2 participants