Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy #182

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Add mypy #182

merged 4 commits into from
Jul 27, 2021

Conversation

cuttlefish
Copy link
Collaborator

@cuttlefish cuttlefish commented Jul 27, 2021 •
edited
Loading

Related Issue(s):
Closes #155

Description:
Adds mypy and hooks it into scripts/lint.
This will be much more useful once stac-utils/pystac#579 is merged and released.
The settings are currently fairly permissive.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • [ ] Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@cuttlefish cuttlefish changed the title Feature/mypy Add mypy Jul 27, 2021
@cuttlefish cuttlefish requested a review from gadomski July 27, 2021 07:43
@cuttlefish cuttlefish mentioned this pull request Jul 27, 2021
Merged
4 tasks
gadomski
gadomski requested changes Jul 27, 2021
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change to the mypy invocation, otherwise looks good. We should probably open another issue to add type signatures to all stactools.{core|cli|testing} functions/methods as well.

scripts/lint Show resolved Hide resolved
@cuttlefish cuttlefish requested a review from gadomski July 27, 2021 17:01
@gadomski gadomski merged commit 5ff21fa into main Jul 27, 2021
gadomski pushed a commit that referenced this pull request Jul 27, 2021
@cuttlefish @gadomski
Update CHANGELOG for #182
df996c0
@gadomski gadomski deleted the feature/mypy branch July 27, 2021 17:03
@cuttlefish cuttlefish mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable mypy
2 participants
@cuttlefish @gadomski