Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scale argument #334

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Remove scale argument #334

merged 1 commit into from
Jul 25, 2022

Conversation

gadomski
Copy link
Member

Related Issue(s):

Description: Implements some suggestions from @pjhartzell.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.

@gadomski
fix: remove scale argument
9143da9 
It was confusing.
@gadomski gadomski requested a review from pjhartzell July 25, 2022 19:32
@gadomski gadomski changed the title Femove scale argument Remove scale argument Jul 25, 2022
pjhartzell
pjhartzell approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gadomski gadomski merged commit 156d3aa into pv/generate-data-footprint Jul 25, 2022
@gadomski gadomski deleted the data-footprint-tweaks branch July 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @pjhartzell