Don't use deprecated methods from pystac #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
disallow-warnings-in-tests
branch
from
f3213bd
to
1359c5e
Compare
gadomski
changed the title
jsignell
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Nice! I think you can set the behavior of warnings based on what library they come from. So for instance you could set only pystac warnings to error. It looks like this: https://github.com/dask/dask/blob/ca4d1d5830a2efe9650aa6485302193c2aacaf7b/pyproject.toml#L129
|
Cool, I'll try the glob. I was trying to do it with exact name and failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disallow warnings in tests, which encourages (nay, forces) us to stop using deprecated items.There are some warnings from stac-check that I'm having trouble filtering out, so for now I'm dropping the "upgrade to error" bit and just fixing the deprecated pystac function usages.PR checklist:
scripts/format).scripts/lint).scripts/test).