do not use namespace eigenpy and define bp #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix on 18.04:
```
[ 94%] Building CXX object unittest/CMakeFiles/std_pair.dir/std_pair.cpp.o
cd /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest && /usr/bin/g++ -Dstd_pair_EXPORTS -I/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0 -isystem /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/include -isystem /usr/lib/python3/dist-packages/numpy/core/include -isystem /usr/include/python3.6 -isystem /usr/include/eigen3 -Wno-long-long -Wall -Wextra -Wcast-align -Wcast-qual -Wformat -Wwrite-strings -Wconversion -pipe -O3 -DNDEBUG -fPIC -std=gnu++14 -o CMakeFiles/std_pair.dir/std_pair.cpp.o -c /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp: In function 'void init_module_std_pair()':
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:28:3: error: reference to 'bp' is ambiguous
bp::def("std_pair_to_tuple", std_pair_to_tuple);
^~
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:8:29: note: candidates are: namespace bp = boost::boost::python;
namespace bp = boost::python;
^
In file included from /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/include/eigenpy/eigenpy.hpp:9:0,
from /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:4:
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/include/eigenpy/fwd.hpp:81:29: note: namespace eigenpy::bp = boost::boost::python;
namespace bp = boost::python;
^
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:29:3: error: reference to 'bp' is ambiguous
bp::def("copy", copy);
^~
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:8:29: note: candidates are: namespace bp = boost::boost::python;
namespace bp = boost::python;
^
In file included from /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/include/eigenpy/eigenpy.hpp:9:0,
from /local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/unittest/std_pair.cpp:4:
/local/robotpkg/var/tmp/robotpkg/math/py-eigenpy/work/eigenpy-3.3.0/include/eigenpy/fwd.hpp:81:29: note: namespace eigenpy::bp = boost::boost::python;
namespace bp = boost::python;
^
```
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 12, 2024
Upstream changelog:
## [3.4.0] - 2024-02-26
### Added
- Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
- Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
- Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
- Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
- Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
- Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
- Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)
### Fixed
- Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
- Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
- Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)
Packaging changes:
- remove patch-aa, fixed upstream
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 29, 2024
Upstream changelog:
## [3.4.0] - 2024-02-26
### Added
- Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
- Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
- Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
- Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
- Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
- Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
- Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)
### Fixed
- Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
- Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
- Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)
Packaging changes:
- remove patch-aa, fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix on 18.04: