Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add std::variant support #431

Merged
merged 16 commits into from
Jan 31, 2024
Merged

Add std::variant support #431

merged 16 commits into from
Jan 31, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Jan 30, 2024 •
edited
Loading

  • Support std::variant
  • Fix support to primitive type (int, bool, float)
  • Add support to boost::blank and std::monostate

There is still some unsupported type : like char

Close #419

@jorisv jorisv self-assigned this Jan 30, 2024
@jorisv jorisv changed the title Add std::variant support Add std::variant support Jan 30, 2024
ManifoldFR
ManifoldFR reviewed Jan 30, 2024
View reviewed changes
unittest/variant.cpp.in Outdated Show resolved Hide resolved
ManifoldFR
ManifoldFR previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@ManifoldFR ManifoldFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

ManifoldFR
ManifoldFR previously approved these changes Jan 30, 2024
View reviewed changes
@jorisv jorisv linked an issue Jan 31, 2024 that may be closed by this pull request
Manage boost::variant by reference #419
Closed
@jorisv jorisv marked this pull request as ready for review January 31, 2024 13:42
ManifoldFR
ManifoldFR approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ManifoldFR ManifoldFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Joris told me it's all good so it must be good

@jorisv jorisv merged commit b07b2c8 into stack-of-tasks:devel Jan 31, 2024
29 checks passed
@jorisv jorisv deleted the topic/add_std_variant branch January 31, 2024 14:49
@jcarpent jcarpent mentioned this pull request Jan 31, 2024
Closed
nim65s added a commit to nim65s/robotpkg that referenced this pull request Mar 12, 2024
@nim65s
[math/py-eigenpy] Update to v3.4.0
a945b02 
Upstream changelog:

    ## [3.4.0] - 2024-02-26

    ### Added
    - Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
    - Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
    - Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
    - Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
    - Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
    - Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
    - Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)

    ### Fixed
    - Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
    - Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
    - Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)

Packaging changes:
- remove patch-aa, fixed upstream
nim65s added a commit to nim65s/robotpkg that referenced this pull request Mar 29, 2024
@nim65s
[math/py-eigenpy] Update to v3.4.0
d6c5545 
Upstream changelog:

    ## [3.4.0] - 2024-02-26

    ### Added
    - Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
    - Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
    - Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
    - Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
    - Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
    - Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
    - Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)

    ### Fixed
    - Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
    - Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
    - Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)

Packaging changes:
- remove patch-aa, fixed upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManifoldFR ManifoldFR ManifoldFR approved these changes

Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage boost::variant by reference
2 participants
@jorisv @ManifoldFR