Add boost::variant support
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
force-pushed
the
topic/add_boost_variant
branch
from
1ebf4de
to
ca7c933
Compare
|
Is it possible to handle other variant types ? Like we did with the PR for optional types where we have a mechanism for both |
jcarpent
approved these changes
Jan 30, 2024
|
@ManifoldFR I will check if it's easy to handle std and boost with the same code |
|
std::variant are slow ;) |
ManifoldFR
reviewed
Jan 30, 2024
| /// bp::make_setter(&VariantHolder::variant)); | ||
| /// } | ||
| template <typename Variant> | ||
| struct BoostVariantConvertor { |
There was a problem hiding this comment.
There's a spelling mistake, it should be "Converter" as in the rest of the library. (not really a mistake because "Convertor" exists but it's very uncommon in English, users might get tripped up)
| bp::class_<V1>("V1", bp::init<>()).def_readwrite("v", &V1::v); | ||
| bp::class_<V2>("V2", bp::init<>()).def_readwrite("v", &V2::v); | ||
|
|
||
| typedef eigenpy::BoostVariantConvertor<MyVariant> Convertor; |
There was a problem hiding this comment.
Also change the spelling in the typedef here to Converter
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 12, 2024
Upstream changelog:
## [3.4.0] - 2024-02-26
### Added
- Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
- Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
- Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
- Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
- Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
- Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
- Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)
### Fixed
- Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
- Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
- Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)
Packaging changes:
- remove patch-aa, fixed upstream
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Mar 29, 2024
Upstream changelog:
## [3.4.0] - 2024-02-26
### Added
- Support for `Eigen::SparseMatrix` types (stack-of-tasks/eigenpy#426)
- Support for `boost::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#430)
- Support for `std::variant` types with `VariantConverter` (stack-of-tasks/eigenpy#431)
- Support for `std::unique_ptr` as a return types with `StdUniquePtrCallPolicies` and `boost::python::default_call_policies` (stack-of-tasks/eigenpy#433)
- Support for `std::unique_ptr` as an internal reference with `ReturnInternalStdUniquePtr` (stack-of-tasks/eigenpy#433)
- Support for `Eigen::Simplicial{LLT,LDLT}` and `Eigen::Cholmod{Simplicial,Supernodal}{LLT,LDLT}` Cholesky de compositions (stack-of-tasks/eigenpy#438)
- Switch to ruff for lints, format, and import sort (stack-of-tasks/eigenpy#441)
### Fixed
- Fix the issue of missing exposition of Eigen types with __int64 scalar type (stack-of-tasks/eigenpy#426)
- Fix namespace use in unittest/std_pair.cpp (stack-of-tasks/eigenpy#429)
- Fix case of zero-size sparse matrices (stack-of-tasks/eigenpy#437)
Packaging changes:
- remove patch-aa, fixed upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoostVariantConverterto register aboost::variantconversion to an alternatives and alternatives conversion toboost::variant.ReturnInternalBoostVariantto return an alternative referenceAlso: